Skip to content

fix: Improve accessibility for links without accessible labels (#1972)#1973

Merged
manudeli merged 1 commit into
toss:mainfrom
myeong-jae-hwi:fix/feature-grid
May 18, 2026
Merged

fix: Improve accessibility for links without accessible labels (#1972)#1973
manudeli merged 1 commit into
toss:mainfrom
myeong-jae-hwi:fix/feature-grid

Conversation

@myeong-jae-hwi
Copy link
Copy Markdown
Contributor

Overview

This PR improves accessibility for links used in the FeatureGrid component by adding accessible labels (aria-label) to unlabeled links.

This helps screen reader users navigate links more effectively and resolves accessibility audit warnings related to missing accessible names.

PR Checklist

  • I did below actions if need
  1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
  2. I added documents and tests.

@coauthors
Copy link
Copy Markdown

coauthors Bot commented May 18, 2026

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1973 (review) #1973 (comment) 2 Co-authored-by: manudeli <61593290+manudeli@users.noreply.github.com>
@myeong-jae-hwi #1973 1 Co-authored-by: myeong-jae-hwi <72872676+myeong-jae-hwi@users.noreply.github.com>
@codecov-commenter #1973 (comment) 1 Co-authored-by: codecov-commenter <65553080+codecov-commenter@users.noreply.github.com>

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 18, 2026

⚠️ No Changeset found

Latest commit: 34e834d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026

@myeong-jae-hwi is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (03f67ee) to head (34e834d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1973   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files          42       42           
  Lines         664      664           
  Branches      163      164    +1     
=======================================
  Hits          619      619           
  Misses         42       42           
  Partials        3        3           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 95.83% <ø> (ø)
@suspensive/react-query-4 100.00% <ø> (ø)
@suspensive/react-query-5 100.00% <ø> (ø)
@suspensive/jotai 100.00% <ø> (ø)
@suspensive/codemods 81.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli
Copy link
Copy Markdown
Member

Thanks

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
suspensive-next-streaming-react-query Ready Ready Preview, Comment May 18, 2026 9:11am
v2.suspensive.org Ready Ready Preview, Comment May 18, 2026 9:11am
v3.suspensive.org Ready Ready Preview, Comment May 18, 2026 9:11am
visualization.suspensive.org Ready Ready Preview, Comment May 18, 2026 9:11am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants