feat(react): support fallback callbacks in Suspense.with#1954
Open
KimHyeongRae0 wants to merge 2 commits into
Open
feat(react): support fallback callbacks in Suspense.with#1954KimHyeongRae0 wants to merge 2 commits into
KimHyeongRae0 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: fd3566e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
People can be co-author:
|
Contributor
|
@KimHyeongRae0 is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 93.22% 93.25% +0.03%
==========================================
Files 42 42
Lines 664 667 +3
Branches 163 165 +2
==========================================
+ Hits 619 622 +3
Misses 42 42
Partials 3 3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1799.
Suspense.withalready receives the wrapped component props when rendering the component, but itsfallbackoption could only be a static React node.This PR allows
fallbackto be a function inSuspense.with, so it can render fallback UI from the same props.AS-IS
The fallback could not use props passed to
Component.TO-BE
The callback form is only supported by
Suspense.with. The regular<Suspense />props are kept as-is.Changes
Suspense.with-specific fallback type<Suspense />@suspensive/reactTest plan
pnpm --filter @suspensive/react ci:test -- src/Suspense.spec.tsxpnpm --filter @suspensive/react ci:typepnpm --filter @suspensive/react ci:eslintpnpm exec oxfmt --check packages/react/src/Suspense.tsx packages/react/src/Suspense.spec.tsx .changeset/suspense-with-fallback-callback.mdPR Checklist