Skip to content

Use consistent _parquet suffix in GDF parquet driver functions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanjmcdougall merged 3 commits into from
Feb 25, 2026
Merged

Use consistent _parquet suffix in GDF parquet driver functions #21

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df669f1
Initial plan
Copilot Feb 23, 2026
a65f481
Rename pin_write_gdf_parquet to pin_write_gdf_geoparquet for consiste…
Copilot Feb 23, 2026
32b8696
Use _parquet suffix consistently: rename pin_read_gdf_geoparquet to p…
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/geopins/drivers/gdf/dispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from geopins.drivers.gdf.filetypes.gpkg import pin_read_gdf_gpkg, pin_write_gdf_gpkg
from geopins.drivers.gdf.filetypes.parquet import (
pin_read_gdf_geoparquet,
pin_write_gdf_parquet,
pin_write_gdf_geoparquet,
)
from geopins.drivers.infer import infer_driver_info
from geopins.interfaces import PinReadKwargDict, PinWriteKwargDict
Expand Down Expand Up @@ -140,7 +140,7 @@ def pin_write_gdf( # noqa: PLR0913
if type_ in ("geopackage", "gpkg"):
return pin_write_gdf_gpkg(x, board=board, **kwargs)
elif type_ == "parquet":
return pin_write_gdf_parquet(x, board=board, **kwargs)
return pin_write_gdf_geoparquet(x, board=board, **kwargs)
else:
raise_driver_not_supported(type_, cls=board.__class__, mode="write")
raise AssertionError # Change to assert_never after deprecating 3.11 support
2 changes: 1 addition & 1 deletion src/geopins/drivers/gdf/filetypes/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def pin_read_gdf_geoparquet(
return gpd.read_parquet(filename)


def pin_write_gdf_parquet( # noqa: PLR0913
def pin_write_gdf_geoparquet( # noqa: PLR0913
Comment thread
nathanjmcdougall marked this conversation as resolved.
Outdated
# N.B. match pins.boards.BaseBoard.pin_write signature
x: GeoDataFrame,
name: str | None = None,
Expand Down