Skip to content

fix race on aptabase sdk init #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nstus merged 1 commit into from
Jul 27, 2026
Merged

fix race on aptabase sdk init #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions apps/twa/src/stub/MiniAppClosed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { Body2, H2, Label2 } from '@tonkeeper/uikit/dist/components/Text';
import { Button } from '@tonkeeper/uikit/dist/components/fields/Button';
import { ChevronRightIcon } from '@tonkeeper/uikit/dist/components/Icon';
import { WalletEmoji } from '@tonkeeper/uikit/dist/components/shared/emoji/WalletEmoji';
import { useAppContext } from '@tonkeeper/uikit/dist/hooks/appContext';
import { useAppSdk } from '@tonkeeper/uikit/dist/hooks/appSdk';
import { useAnalyticsTrack } from '@tonkeeper/uikit/dist/hooks/analytics';
import { useAccountLabel } from '@tonkeeper/uikit/dist/hooks/accountUtils';
Expand Down Expand Up @@ -203,27 +204,28 @@ const DownloadButton: FC<{ sdk: TwaAppSdk }> = ({ sdk }) => {
export const MiniAppClosed: FC<{ sdk: TwaAppSdk }> = ({ sdk }) => {
const { t } = useTranslation();
const client = useQueryClient();
const { tracker } = useAppContext();
const track = useAnalyticsTrack();
const { data: accounts } = useAccountsStateQuery();

// Only accounts with a recoverable secret belong in the list — watch-only,
// hardware and other non-mnemonic accounts have no recovery phrase to show.
const recoverableAccounts = (accounts ?? []).filter(isMnemonicAndPassword);

// Reach metric: fire once per session, after the account list has loaded so
// has_wallets / wallets_count reflect the real state rather than the empty
// pre-load list.
// Reach metric: fire once per session, after the account list and analytics
// tracker have loaded so the event is not lost to the tracker's initial
// no-op state.
const openTracked = useRef(false);
useEffect(() => {
if (accounts === undefined || openTracked.current) return;
if (accounts === undefined || !tracker || openTracked.current) return;
openTracked.current = true;
track({
eventName: 'twa_sunset_open',
telegram_platform: toSunsetPlatform(sdk.launchParams.platform),
has_wallets: recoverableAccounts.length > 0,
wallets_count: recoverableAccounts.length
});
}, [accounts, recoverableAccounts.length, sdk, track]);
}, [accounts, recoverableAccounts.length, sdk, track, tracker]);

const [passwordAccount, setPasswordAccount] = useState<Account | null>(null);
const [recovery, setRecovery] = useState<{ account: Account; secret: AccountSecret } | null>(
Expand Down
Loading