Repository navigation
chore: release 1.0.0 - #44
Merged
Merged
Conversation
The previous attempt did not take. release-please reads Release-As as a footer, and this repository squash merges, so a pull request carrying two commits produced one message with both bodies concatenated. The footer ended up in the middle, where it is ignored, and the release-policy commit that followed it was correct but silent. This pull request has a single commit so the footer stays last, and AGENTS.md now records the interaction so the next person forcing a version does not lose an afternoon to it. Worth noting what 0.11.1 was: the README split, published by a documentation only change. That is exactly the behaviour the previous pull request fixed, and it merged one commit too early to benefit from its own fix. Release-As: 1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Release-As: 1.0.0in #41 did not take effect. This retries it correctly.Why it failed
release-please reads
Release-Asas a commit message footer, meaning the last thing in the message. This repository squash merges, so #41's two commits were concatenated into one message:The footer ended up in the middle and was ignored. Everything else in #41 landed correctly; only the version forcing was silent.
This PR has a single commit, so the footer stays last.
AGENTS.mdnow records the interaction, since it is not obvious and cost a release cycle here.While we are here: what
0.11.1wasThe README split. A documentation-only change published a version to npm.
That is precisely the behaviour #41 fixed, and #42 merged one commit too early to benefit from its own fix. From now on
docs,chore,ci,test,styleandbuildcut no release, which this PR will demonstrate: it is achore:, and without the explicitRelease-Asit would produce nothing at all.What 1.0.0 contains
Merging this opens the
1.0.0Release PR covering everything since0.11.1:measure,sleep,heart,user,notify,signature,oauth2WithingsApiError,WithingsHttpError,WithingsInvalidResponseError