add support for illumos target#2486
Merged
Merged
Conversation
Although very similar in many regards, illumos and Solaris have been diverging since the end of OpenSolaris. With the addition of illumos as a Rust target, it must be wired into the same interfaces which it was consuming when running under the 'solaris' target.
Darksonn
added
A-tokio
Darksonn
approved these changes
May 11, 2020
Member
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
I have no way to test this, but if you say you've tested it and that it works, merging this is ok with me.
Contributor
Author
Without the change, tokio fails to even build on illumos. I tested with toolchain binaries built from the scripts we're trying to get upstream in order to be supported by the nightly builds. With those binaries and this patch, the test suite passes. Thanks |
jensim
pushed a commit
to jensim/tokio
that referenced
this pull request
Jun 7, 2020
Although very similar in many regards, illumos and Solaris have been diverging since the end of OpenSolaris. With the addition of illumos as a Rust target, it must be wired into the same interfaces which it was consuming when running under the 'solaris' target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although very similar in many regards, illumos and Solaris have been
diverging since the end of OpenSolaris. With the addition of illumos as
a Rust target, it must be wired into the same interfaces which it was
consuming when running under the 'solaris' target.
Motivation
With the addition of the illumos target and subsequent to various dependencies (like mio), it would be nice for Tokio to be supported on illumos.
Solution
Since
ucredfunctions the same on illumos as it does on Solaris, they can share that logic.