Convert to jekyll#13
Draft
karbassi wants to merge 3 commits into
Draft
Conversation
Open
Contributor
|
Sorry I'm just now getting to this. Here's my review.
Everything else looks fine to me. I got no errors. Some differences from the current site (not sure if you're aware):
With the most important parts converted to Jekyll, making a new design with the site content should be a lot easier now. These are all of the things that I noticed. Glad that you took the time to do this! |
Contributor
|
Can you check my review? Would like to see this merged into master. |
Contributor
|
@donovanglover and @karbassi what's needed to move this forward? I posted karbassi#1 which is based on this PR (and similar change for existing html version #50 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14