Skip to content

session replay sample rate 수치 조정 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baekteun merged 1 commit into from
Mar 29, 2026
Merged

session replay sample rate 수치 조정 #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Projects/App/iOS/Support/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>CFBundlePackageType</key>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>12.3</string>
<string>12.4</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
Expand All @@ -34,7 +34,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>89</string>
<string>90</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSRequiresIPhoneOS</key>
Expand Down
2 changes: 1 addition & 1 deletion Projects/Shared/TWLog/Sources/TWLog.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public enum TWLog {
#endif

#if os(iOS)
amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: 1.0))
amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: 0.03))
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

매직 넘버 0.03을 직접 사용하는 것보다 상수로 정의하여 코드의 가독성과 유지보수성을 높이는 것이 좋습니다. 이렇게 하면 나중에 값을 변경하기가 더 쉬워집니다.

        let sessionReplaySampleRate = 0.03
        amplitude.add(plugin: AmplitudeSwiftSessionReplayPlugin(sampleRate: sessionReplaySampleRate))

#endif

return amplitude
Expand Down
Loading