[1832] Add system code to corporation, add logic for system train buys.#12764
Open
jemiahlee wants to merge 1 commit into
Open
[1832] Add system code to corporation, add logic for system train buys.#12764jemiahlee wants to merge 1 commit into
jemiahlee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeExplanation of Change
This PR adds a little bit of functionality to corporation to distinguish the system from other corps, and adds train buy functionality for Systems, which are allowed to voluntarily buy as long as the system has <= current train limit (basically one of the shells must be able to be configured with zero trains, though there is no such need for actually configuring them). The president is allowed to contribute cash for that voluntary buy.