[18ESP] adds simple logos#12758
Open
philcampeau wants to merge 2 commits into
Open
Conversation
perwestling
requested changes
Jun 14, 2026
perwestling
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed with AI assistance by Mistral Vibe
✅ Strengths
- Adds simple (alternative) logos for 18_esp corporations
- Uses correct naming convention:
{BASE}.alt.svg(e.g.,18_esp/A.alt.svg) - Files stored in correct location:
public/logos/18_esp/ - Uses
generate_logos.rbscript for consistency - Improves accessibility for players with vision difficulties
- All other logos look fine
⚠️ Requested Changes
- Fix text color contrast for logos with light backgrounds: MH (pink), CA (light yellow), SC (bright yellow)
- Suggestion: Regenerate with black text (
fill="#000000") for better visibility
❌ Verdict: Request changes
Please address the text color contrast issue for the three noted logos, then this will be ready for approval.
Collaborator
Author
|
Good catch. Fixed the light-coloured tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Adds Simple Logos created with the generate_logos.rb script.
Screenshots
Any Assumptions / Hacks