[1880 Romania] Game uses standard float#12753
Open
philcampeau wants to merge 1 commit into
Open
Conversation
philcampeau
added
rules-broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12740
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
In the original 1880 China, corporations only floated if the president held a certain percentage of shares at the end of the SR where the corp was parred.
1880 Romania does away with this rule, and now floating is strictly based on initially selling a certain percentage from the IPO.
I didn't initially implement this because it wasn't mentioned in Lonny's rules-differences file he provided me.
I put the archive tag because it's possible some games may not work after this change, if a player bought enough shares to float their corp and then sold down before the end of that SR. Otherwise, everything should be good.
Screenshots
Any Assumptions / Hacks