[18ZOO] Fix Info tab when all corporations are open#12751
Open
carlorusso1984 wants to merge 2 commits into
Open
[18ZOO] Fix Info tab when all corporations are open#12751carlorusso1984 wants to merge 2 commits into
carlorusso1984 wants to merge 2 commits into
Conversation
perwestling
previously approved these changes
Jun 14, 2026
Collaborator
There was a problem hiding this comment.
PR Review: #12751 - [18ZOO] Fix Info tab when all corporations are open
Reviewed with AI assistance by Mistral Vibe
✅ Strengths
- Fixes documented issue (#12737)
- Minimal, surgical change (2 lines in game.rb)
- Adds regression test (8 lines in spec)
- Clean Ruby idiom: uses
unlessmodifier instead of guard clause + return - Handles edge case: empty following_corporations
❓ Questions
- Have you verified the fix works correctly in the UI (Info tab displays properly)?
✅ Verdict: Approve
The fix is correct, well-tested, and follows Ruby best practices. Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12737
Summary
timelinereturning an array when no unopened corporation follows the purchasable familyTesting
ruby -c lib/engine/game/g_18_zoo/game.rbruby -c spec/lib/engine/game/g_18_zoo/game_spec.rbgit diff --checkRSpec and RuboCop could not be run locally because Bundler 2.5.13 is unavailable and the Docker daemon is not running.