Skip to content

[18ZOO] Fix Info tab when all corporations are open#12751

Open
carlorusso1984 wants to merge 2 commits into
tobymao:masterfrom
carlorusso1984:codex/fix-18zoo-info-tab
Open

[18ZOO] Fix Info tab when all corporations are open#12751
carlorusso1984 wants to merge 2 commits into
tobymao:masterfrom
carlorusso1984:codex/fix-18zoo-info-tab

Conversation

@carlorusso1984

Copy link
Copy Markdown
Contributor

Closes #12737

Summary

  • keep timeline returning an array when no unopened corporation follows the purchasable family
  • omit the Nearby Family message in that state
  • add a regression spec for the affected state

Testing

  • ruby -c lib/engine/game/g_18_zoo/game.rb
  • ruby -c spec/lib/engine/game/g_18_zoo/game_spec.rb
  • git diff --check

RSpec and RuboCop could not be run locally because Bundler 2.5.13 is unavailable and the Docker daemon is not running.

perwestling
perwestling previously approved these changes Jun 14, 2026

@perwestling perwestling left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: #12751 - [18ZOO] Fix Info tab when all corporations are open

Reviewed with AI assistance by Mistral Vibe


✅ Strengths

  • Fixes documented issue (#12737)
  • Minimal, surgical change (2 lines in game.rb)
  • Adds regression test (8 lines in spec)
  • Clean Ruby idiom: uses unless modifier instead of guard clause + return
  • Handles edge case: empty following_corporations

❓ Questions

  • Have you verified the fix works correctly in the UI (Info tab displays properly)?

✅ Verdict: Approve

The fix is correct, well-tested, and follows Ruby best practices. Ready to merge.

@perwestling perwestling dismissed their stale review June 15, 2026 19:31

Remove AI assisted approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[18Zoo] Info tab no longer working

2 participants