[1880 Romania] Add 1880 Romania Transilvania variant#12738
Open
perwestling wants to merge 4 commits into
Open
Conversation
perwestling
added
new games
perwestling
changed the title
perwestling
commented
Jun 6, 2026
Tests cover: - Game meta configuration (title, player range, dev stage, dependencies) - Game constants (starting cash, cert limit) - Game initialization (companies, minors, corporations with coordinates) - Train configuration (quantities, events for 2+2, 3+3, 6E, 8E, 2R) - Par chart functionality - Dummy companies for unused privates (P2, P4, P6, P7) - Map configuration (layout, axes, location names, hexes, offboard) Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1880 Romania] Adds the Transilvania 2 player variant to 1880 Romania.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeNew variant, so no games to archive/pin.
Implementation Notes
This is an initial commit that implements a variant using a 2-player
Transilvania map. Based on 1880 Romania it removes and changes things
based on the variant by Lonny.
Some companies from 1880 China or 1880 Romania are not applicable for 1880 Romania Transilvania
and have therefor been overridden with empty implementation.
Companies and minors are a subset of the ones in 1880 Romania.
Corporations and Foreign investors use different coordinates compared to 1880 Romania.
Have added some simple unit tests. And a game end fixture to test the only supported game end.
Explanation of Change
Have made changes needed for 2 player variant.
Played a hot seat game to completion.
Screenshots
N/A
Any Assumptions / Hacks
N/A