[1862 USA & Canada] PR 04: SR mechanics — GHU discount, NYH par lock, private close triggers#12736
Open
neutronc wants to merge 3 commits into
Open
[1862 USA & Canada] PR 04: SR mechanics — GHU discount, NYH par lock, private close triggers#12736neutronc wants to merge 3 commits into
neutronc wants to merge 3 commits into
Conversation
…$100 GHU (Bahnhoflizenz): fix owner_type corporation→player; custom Token step auto-applies the $80 discount (min $0) when the operating corp's director owns GHU. NHSC/NYH: custom BuySellParShares step restricts NYH par prices to exactly $100. NHSC gives the buyer NYH's director cert; the par price is locked by rule regardless of market availability. Both step files wired into stock_round and operating_round. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SOC closes when CPR or UP floats; NHSC closes when NYH floats. PSC closes on WP's first dividend; FNY closes on NYC's first dividend. TOR auto-closes via closed_when_used_up on its tile_lay ability. Custom Step::Dividend detects first payout via operating_history and calls game.on_first_payout! to fire the trigger. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ollybh
reviewed
Jun 6, 2026
…or nyh_par_prices Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12623
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Two SR/OR mechanic features for 1862 USA & Canada:
GHU token discount + NYH par price lock
Step::Tokenoverride.Step::BuySellParSharesblocks other par prices for NYH.Private company close triggers
closed_when_used_upon its tile-lay ability).Step::Dividendoverride handles first-payout detection for PSC/FNY.Screenshots
N/A — no tile or map changes.
Any Assumptions / Hacks
None.