fix: replace pgxconn with pgxpool to fix pgvector connection management issue#1457
Open
rickif wants to merge 1 commit into
Open
fix: replace pgxconn with pgxpool to fix pgvector connection management issue#1457rickif wants to merge 1 commit into
rickif wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.This PR replaces the usage of pgconn with pgxpool in the pgvector integration to address the connection issue caused by
failed to deallocate cached statement(s): conn closederrors in pgx.Context cancellation may close the pgxconn, causing subsequent queries to fail. More detail in jackc/pgx#2100.
pgxpool will automatically close the disconnected pgxconn and create a new one when necessary, resolving this issue.