Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BeyondMS The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
BeyondMS
force-pushed
the
feat-platform-add-etcd-config
branch
from
8c7c3bd to
4288ced
Compare
|
/assign @huxiaoliang |
| for k, v := range c.Spec.APIServerExtraArgs { | ||
| args[k] = v | ||
| } | ||
|
|
There was a problem hiding this comment.
why remove above lines?
There was a problem hiding this comment.
it's redundant. the assignment has been done in the next line "utilruntime.Must(mergo.Merge(&args, c.Spec.APIServerExtraArgs))"
| } | ||
| for k, v := range c.Spec.ControllerManagerExtraArgs { | ||
| args[k] = v | ||
| } |
There was a problem hiding this comment.
why remove above lines?
There was a problem hiding this comment.
it's redundant. the assignment has been done in the next line.
| for k, v := range c.Spec.SchedulerExtraArgs { | ||
| args[k] = v | ||
| } | ||
|
|
There was a problem hiding this comment.
why remove above lines?
There was a problem hiding this comment.
it's redundant. the assignment has been done in the next line.
3 participants
What type of PR is this?
What this PR does / why we need it:
We want to start etcd with extra arguments.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: