docs: pin dead tinymemory core/src link to the vendored commit - #5654
Open
JMak-Security wants to merge 1 commit into
Open
docs: pin dead tinymemory core/src link to the vendored commit#5654JMak-Security wants to merge 1 commit into
JMak-Security wants to merge 1 commit into
Conversation
src/openhuman/memory/README.md linked https://github.com/tinyhumansai/tinymemory/tree/main/core/src, which 404s: tinymemory's main branch restructured into a Cargo workspace (core/ became crates/tinymemory-core/), so a floating main-branch link no longer resolves. The vendored submodule at vendor/tinymemory is still pinned to commit 38a34d2 (pre-restructure), where core/src genuinely exists with all six files the README names (sync_events.rs, remember.rs, ingest_pipeline.rs, traits.rs, preferences.rs, rpc_models.rs) -- verified directly against that commit's tree. Pinning the link to that exact commit SHA instead of main fixes the 404 while staying accurate to what's actually vendored, rather than pointing to tinymemory's current (and possibly further-diverged) structure. Signed-off-by: Jason Mak <squrrielbro@gmail.com>
![tinysweeper[bot]](https://avatars.githubusercontent.com/in/4526585?s=60&v=4){kind=small}
tinysweeper
Bot
added
the
priority: p3
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe memory README now links extracted ChangesMemory documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change pins a broken documentation link to the vendored commit where the referenced files exist; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
YellowSnnowmann
added a commit
to YellowSnnowmann/openhuman
that referenced
this pull request
Aug 21, 2026
`Markdown Link Check` went red on this branch: `src/openhuman/memory/README.md` links to `tinymemory/tree/main/core/src`, and upstream tinyhumansai#73 moved every crate under `crates/`, so that path is a 404. The README link is now pinned to the commit this branch vendors (`1d6b997`) rather than to `main`, so it describes the code the repo actually compiles and cannot rot the next time upstream moves a directory. Overlaps tinyhumansai#5654, which pins the same line to the *previous* vendored commit; whichever lands second should keep the SHA that matches the submodule. The same rename left six links in `gitbooks/features/obsidian-wiki/scoring.md` and one path in `AGENTS.md` pointing at directories that no longer exist. Those are outside the link checker's globs, so nothing reported them. All seven targets verified to resolve. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/openhuman/memory/README.mdlinks tohttps://github.com/tinyhumansai/tinymemory/tree/main/core/src, which now 404s -- caught by this repo's ownMarkdown Link CheckCI job (lychee) on an unrelated PR (#5650).Root cause
tinymemory'smainbranch has since restructured into a Cargo workspace:core/becamecrates/tinymemory-core/. A link pinned tomainstopped resolving once that migration landed, even though nothing in this repo changed.Fix
vendor/tinymemory(this repo's submodule) is still pinned to commit38a34d2ea10e7eedda1b50cdc786016c0f73b6dc, from before the restructure. At that exact commit,core/srcexists and contains all six files the README names by path (sync_events.rs,remember.rs,ingest_pipeline.rs,traits.rs,preferences.rs,rpc_models.rs) -- verified directly against that commit's tree via the GitHub API.Pinning the link to that commit SHA instead of
mainfixes the 404 while staying accurate to what's actually vendored here, rather than repointing to tinymemory's current (and possibly further-diverged) directory layout.Testing
core/srcat commit38a34d2contains exactly the six files/dirs the README describes.tree/main/core/src): 404tree/38a34d2.../core/src): 200Split out of #5650 as an unrelated, separately-scoped fix.
Summary by CodeRabbit
tinymemory-coresource reference to a fixed version for improved consistency and reproducibility.