Skip to content

fix(mcp): add uvx PATH preflight check and actionable guidance (#5600) - #5618

Closed
shivakumar777-web wants to merge 2 commits into
tinyhumansai:mainfrom
shivakumar777-web:fix/mcp-uvx-path-preflight
Closed

fix(mcp): add uvx PATH preflight check and actionable guidance (#5600)#5618
shivakumar777-web wants to merge 2 commits into
tinyhumansai:mainfrom
shivakumar777-web:fix/mcp-uvx-path-preflight

Conversation

@shivakumar777-web

@shivakumar777-web shivakumar777-web commented Aug 20, 2026

Copy link
Copy Markdown

Closes #5600

Summary of Changes

  • Added Windows %LOCALAPPDATA%\Programs\uv\bin\ and standard \uv\ installation fallback directories to \�ersion_manager_dirs()\ in \spawn_env.rs.
  • Added unit test \initialize_missing_uvx_mentions_uv_and_docs_link\ in \stdio.rs\ verifying that missing \uvx\ produces actionable installation guidance pointing to \https://docs.astral.sh/uv/\.

Verification

  • \cargo test --manifest-path Cargo.toml --lib openhuman::mcp::config_servers::stdio\ (passed)
  • \cargo check --manifest-path Cargo.toml\ (passed)

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows command resolution by recognizing commonly used local application directories.
    • Enhanced error messages when an uvx-based connection cannot start, including guidance for installing uv (Python) and a link to official documentation.

@shivakumar777-web
shivakumar777-web requested a review from a team August 20, 2026 11:37
@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 20, 2026

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 120 embedded · openrouter/openai/text-embedding-3-small

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 07f99839-1a6f-4bb7-a0ae-8b8368e5a3d9

📥 Commits

Reviewing files that changed from the base of the PR and between 157a07a and 3d612e0.

📒 Files selected for processing (1)
  • src/openhuman/mcp/config_servers/spawn_env.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/openhuman/mcp/config_servers/spawn_env.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The Windows uv path fallback expression was reformatted. An async stdio test verifies actionable diagnostics when uvx is unavailable.

Changes

uvx resolution and diagnostics

Layer / File(s) Summary
Windows PATH fallback formatting
src/openhuman/mcp/config_servers/spawn_env.rs
The Windows uv path fallback call was reformatted. Directory discovery behavior is unchanged.
Missing uvx diagnostic validation
src/openhuman/mcp/config_servers/stdio.rs
An async test verifies that missing uvx errors mention uv (Python) and the official uv documentation URL.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 3d612

The change adds localized uvx PATH detection and actionable installation guidance, with the stated tests and checks passing; no actionable merge-blocking risk remains.

Poem

I check the path from hop to hop,
And test the message when tools stop.
If uvx is missing from the way,
Clear docs now guide the fix today.
— A careful rabbit 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the MCP change: an uvx PATH preflight check with actionable guidance.
Linked Issues check ✅ Passed The changes address issue #5600 by checking uvx availability and testing actionable installation guidance for missing uv.
Out of Scope Changes check ✅ Passed The path handling update and async test directly support the uvx preflight check and issue #5600.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 20, 2026
@M3gA-Mind

Copy link
Copy Markdown
Collaborator

Closing this — not because the idea is wrong, but because the code it changes no longer exists in this repository.

Both files this PR touches were removed when the MCP client was extracted into tinyhumansai/tinymcp (commit 050b2d687):

  • src/openhuman/mcp/config_servers/spawn_env.rs — gone from main
  • src/openhuman/mcp/config_servers/stdio.rs — gone from main

src/openhuman/mcp/config_servers/ is not present on main at all, which is why this shows as CONFLICTING/DIRTY: there is no longer a base to rebase onto. That happened after this PR was opened — it was written against an accurate tree at the time.

If you would like to carry the work forward, the equivalent code now lives in vendor/tinymcp/crates/tinymcp/src/lib.rs. A PR against tinyhumansai/tinymcp would reach openhuman through a submodule bump.

One thing worth flagging for whoever picks it up: this PR carries Closes #5600, and a preflight check would not actually close that issue. The reported failure there is that uv is not installed on the staging host — better error messaging makes the failure legible, it does not install the dependency. Those are two separate deliverables, so a future PR should reference the issue without a closing keyword.

#5600 remains open.

@M3gA-Mind M3gA-Mind closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Staging: GitHub MCP server fails — uvx not found on PATH (uv not installed)

2 participants