Skip to content

fix(deps): raise optional-extra floors past known-vulnerable releases - #314

Merged
andrevanzuydam merged 1 commit into
v3from
fix/extras-vulnerable-floors
Nov 13, 2026
Merged

andrevanzuydam merged 1 commit into
v3from
fix/extras-vulnerable-floors

Conversation

@andrevanzuydam

Copy link
Copy Markdown
Collaborator

Why Snyk keeps failing. security/snyk has failed on every PR that touches pyproject.toml, including the 3.13.162 and 3.13.163 release PRs. tina4-python has no runtime dependencies, and all 61 packages pinned in uv.lock have 0 known advisories (checked against OSV). Snyk scans the manifest, though, and three optional extras declare floors that still allow vulnerable releases. So a fresh pip install tina4-python[push] (or [mysql], [mongo], [all-db], [test]) could resolve one.

Extra spec Lowest allowed version had New floor Advisories at new floor
cryptography>=42.0 15 advisories (49.x still has GHSA-g6cj-pr64-35w5 / PYSEC-2026-3552) >=50.0.0 0
mysql-connector-python>=9.0 GHSA-hgjp-83m4-h4fj, PYSEC-2026-1685 >=9.1.0 0
pymongo>=4.18.2 GHSA-98qm-wvgf-w4cf >=4.18.3 0

uv.lock is regenerated without --upgrade, so every pinned version is unchanged. The locked cryptography 50.0.1, mysql-connector-python 9.6.0 and pymongo 4.18.3 were already above the new floors. The only lock change is the stale tina4-python self-entry, 3.13.157 → 3.13.163.

Proof: this PR changes pyproject.toml, so Snyk scans it. A pass here confirms these floors were the finding. PHP, Ruby and Node passed Snyk on their 3.13.163 manifest changes, so this is Python-only.

🤖 Generated with Claude Code

Three optional extras declared lower bounds that still admit releases
with published advisories, so a fresh `pip install tina4-python[push]`
(or [mysql] / [mongo] / [all-db] / [test]) could resolve a vulnerable
version. That is what the Snyk manifest scan has been flagging on every
pyproject.toml change (it failed on both the 3.13.162 and 3.13.163
release PRs). The locked versions were never affected.

- cryptography >=42.0   -> >=50.0.0  (42.0 carries 15 advisories; 49.x
  still 2: GHSA-g6cj-pr64-35w5 / PYSEC-2026-3552, fixed in 50.0.0)
- mysql-connector-python >=9.0 -> >=9.1.0  (GHSA-hgjp-83m4-h4fj, PYSEC-2026-1685)
- pymongo >=4.18.2 -> >=4.18.3  (GHSA-98qm-wvgf-w4cf)

Each new floor has 0 known advisories in OSV. uv.lock is regenerated
without --upgrade: every pinned version is unchanged (the locked
cryptography 50.0.1, mysql-connector-python 9.6.0 and pymongo 4.18.3
already sat above the new floors); only the stale tina4-python
self-entry moves 3.13.157 -> 3.13.163.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Tina4 <82961293+tina4stack@users.noreply.github.com>
Signed-off-by: Andre van Zuydam <andrevanzuydam@gmail.com>
@andrevanzuydam
andrevanzuydam merged commit c2e086d into v3 Nov 13, 2026
13 of 14 checks passed
@andrevanzuydam
andrevanzuydam deleted the fix/extras-vulnerable-floors branch November 13, 2026 14:05
@andrevanzuydam

Copy link
Copy Markdown
Collaborator Author

Follow-up: Snyk still fails on this PR, so these floors were not (all of) what Snyk flags. Merged anyway, because they genuinely allowed releases with published advisories, and the new floors have 0 in OSV.

What's left is visible only in Snyk's own data. Every pinned package in uv.lock and every extra floor is clean in OSV. The likely suspect is Snyk's licence policy rather than a vulnerability (mysql-connector-python is GPL-2.0 with a FOSS exception), but that's unconfirmed. Report: https://app.snyk.io/org/tina4stack/pr-checks/22e881df-eaa3-4d19-8c7e-765b6629a9fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant