Repository navigation
test(database): lock the pgsql:// scheme-alias contract (#280 parity) - #207
Merged
Merged
Conversation
Parity lock for tina4-php#280, where Database::create refused pgsql:// although DatabaseUrl mapped it. Python already accepts pgsql (issue #58); this test locks it so it cannot silently regress: every documented scheme (sqlite/sqlite3, postgres/postgresql/pgsql, mysql, mssql/sqlserver, firebird) resolves, the postgres and mssql aliases resolve to the same adapter as their canonical engine, and an unknown scheme is refused rather than falling through to SQLite. No mocks: sqlite aliases round-trip against a real in-memory database; server aliases are checked against the real driver registry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Andre van Zuydam <andrevanzuydam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parity lock for tina4stack/tina4-php#280 (where
Database::createrefusedpgsql://although the URL parser mapped it). Python already acceptspgsql(issue #58); this locks the contract so it can't silently regress.Asserts the full cross-framework scheme set resolves —
sqlite/sqlite3→sqlite,postgres/postgresql/pgsql→postgres,mysql,mssql/sqlserver→mssql,firebird— that the postgres/mssql aliases resolve to the same adapter as their canonical engine, and that an unknown scheme is refused (never falls through to SQLite).No mocks: the sqlite aliases round-trip against a real in-memory database; the server-engine aliases are checked against the real driver registry. 11 assertions, green.
🤖 Generated with Claude Code