Skip to content

Allow parallel execution of live updates #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rafaelgallani wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow parallel execution of live updates #6661

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b083811
make live update work in parallel
rafaelgallani Jan 11, 2026
85e73ae
improve comments
rafaelgallani Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions internal/controllers/core/liveupdate/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,13 @@ func NewFakeReconciler(
}

func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
r.mu.Lock()
defer r.mu.Unlock()
state := r.store.RLockState()
available := state.AvailableBuildSlots()
r.store.RUnlockState()

if available < 1 {
return ctrl.Result{RequeueAfter: 100 * time.Millisecond}, nil
}

lu := &v1alpha1.LiveUpdate{}
err := r.client.Get(ctx, req.NamespacedName, lu)
Expand All @@ -126,7 +131,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Resu

if apierrors.IsNotFound(err) || lu.ObjectMeta.DeletionTimestamp != nil {
r.store.Dispatch(liveupdates.NewLiveUpdateDeleteAction(req.Name))
delete(r.monitors, req.Name)
r.deleteMonitor(req.Name)
return ctrl.Result{}, nil
}

Expand Down Expand Up @@ -249,9 +254,21 @@ func (r *Reconciler) handleFailure(ctx context.Context, lu *v1alpha1.LiveUpdate,
return ctrl.Result{}, err
}

// Remove a monitor when its LiveUpdate is deleted.
// Locks because r.monitors may be accessed concurrently.
func (r *Reconciler) deleteMonitor(name string) {
r.mu.Lock()
defer r.mu.Unlock()
delete(r.monitors, name)
}

// Create the monitor that tracks a live update. If the live update
// spec changes, wipe out all accumulated state.
// Locks because r.monitors may be accessed concurrently.
func (r *Reconciler) ensureMonitorExists(name string, obj *v1alpha1.LiveUpdate) *monitor {
r.mu.Lock()
defer r.mu.Unlock()

spec := obj.Spec
m, ok := r.monitors[name]
if ok && apicmp.DeepEqual(obj.Spec, m.spec) {
Expand Down