Skip to content

Support logging data with nil exception #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kcdragon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support logging data with nil exception #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ougai/logger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def to_item(args)

if msg.nil?
{ msg: @default_message }
elsif ex.nil?
elsif ex.nil? && data.nil?
create_item_with_1arg(msg)
elsif data.nil?
create_item_with_2args(msg, ex)
Expand Down
18 changes: 18 additions & 0 deletions spec/logger_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,24 @@ def to_hash
end
end

context 'with message, nil exception and data' do
it 'outputs valid' do
logger.send(method, log_msg, nil, something: { name: 'foo' })

expect(item).to be_log_message(log_msg, log_level)
expect(item).to include_data(something: { name: 'foo' })
end

it 'outputs valid by block' do
logger.send(method) do
[log_msg, nil, something: { name: 'foo' }]
end

expect(item).to be_log_message(log_msg, log_level)
expect(item).to include_data(something: { name: 'foo' })
end
end

context 'without arguments' do
it 'outputs only default message' do
logger.send(method)
Expand Down