Skip to content

Add global CLI preferences - #26

Merged
Icemap merged 1 commit into
mainfrom
agent/global-preferences
Jul 28, 2026
Merged

Add global CLI preferences#26
Icemap merged 1 commit into
mainfrom
agent/global-preferences

Conversation

@Icemap

@Icemap Icemap commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add the optional hidden ~/.tdc/.preferences TOML file for process-wide logging and future telemetry preferences
  • move operation logging configuration out of profile-scoped ~/.tdc/config, with strict parsing, fail-closed behavior, and idempotent legacy migration
  • reserve the logging profile name and keep every tdc update form isolated from all ~/.tdc/ state
  • move the completed global-settings spec to done/ and renumber the remaining telemetry and distribution specs
  • synchronize README, product principles, AGENTS guidance, and the PingCAP documentation PR

Why

Global logging and telemetry preferences are not profiles. Keeping [logging] in the profile document made profile persistence responsible for preserving unrelated global state and left future telemetry configuration without a clear ownership boundary. The hidden preferences file makes advanced global controls explicit without adding another public command.

User Impact

Users can persistently configure global logging in ~/.tdc/.preferences or override it for one process with TDC_LOGGING. Existing [logging] values in ~/.tdc/config migrate automatically. Fresh installs and tdc configure do not create the preferences file, and malformed preferences never fail the requested command.

Related documentation: pingcap/docs#23306

Validation

  • make test
  • make e2e
  • git diff --check
  • PingCAP docs git diff --check

@Icemap
Icemap marked this pull request as ready for review July 28, 2026 07:33
@Icemap
Icemap merged commit f3c8aa5 into main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant