edk2toollib: Fix Pcds are not parsed when next to symbol#798
Merged
Javagedes merged 1 commit intotianocore:masterfrom Apr 7, 2026
Merged
Conversation
PaddyDengAmi
force-pushed
the
user/paddydeng/PcdNextToSymbols
branch
from
e2c03e9 to
95f98d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 47 47
Lines 7881 7881
=======================================
Hits 6471 6471
Misses 1410 1410 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The original str.split in ReplacePcds yields incorrect result when the pcd is right next to symbols. Sign-off-by: Paddy Deng <paddydeng@ami.com>
PaddyDengAmi
force-pushed
the
user/paddydeng/PcdNextToSymbols
branch
from
95f98d3 to
70231fc
Compare
Javagedes
approved these changes
Apr 7, 2026
Contributor
|
This looks great. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original string.split in ReplacePcds yelds incorrect result when the pcd is right next to symbols.
Sign-off-by: Paddy Deng paddydeng@ami.com