SourceTable: Filter directories from source file glob results#797
Merged
Javagedes merged 1 commit intotianocore:masterfrom Mar 30, 2026
Merged
SourceTable: Filter directories from source file glob results#797Javagedes merged 1 commit intotianocore:masterfrom
Javagedes merged 1 commit intotianocore:masterfrom
Conversation
Path.rglob("*.c") matches both files and directories. When a
submodule contains a directory whose name ends with a source
extension (e.g. oqs-provider/oqs-template/oqsprov/oqs_kmgmt.c),
_parse_file() raises IsADirectoryError because it attempts to
open() the directory path.
Add a file.is_file() guard to the existing filter so only regular
files are passed to _parse_file().
Signed-off-by: Doug Flick <dougflick@microsoft.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 47 47
Lines 7881 7881
=======================================
Hits 6471 6471
Misses 1410 1410 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Javagedes
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.rglob("*.c") matches both files and directories. When a submodule contains a directory whose name ends with a source extension (e.g. oqs-provider/oqs-template/oqsprov/oqs_kmgmt.c), _parse_file() raises IsADirectoryError because it attempts to open() the directory path.
This becomes a problem trying to test against large third party vendored code (e.g. Openssl).
Add a file.is_file() guard to the existing filter so only regular files are passed to _parse_file().