Skip to content

Add PackageListingInline to allow listing listings to new communities through Django Admin#1240

Open
x753 wants to merge 1 commit intomasterfrom
list-listings-through-django-admin
Open

Add PackageListingInline to allow listing listings to new communities through Django Admin#1240
x753 wants to merge 1 commit intomasterfrom
list-listings-through-django-admin

Conversation

@x753
Copy link
Copy Markdown
Contributor

@x753 x753 commented Mar 18, 2026

Add PackageListingInline so we can list listings
to new communities through the Django Admin

Add PackageListingInline so we can list listings
to new communities through the Django Admin
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 918b65ac-79b3-4259-bd9f-613288884911

📥 Commits

Reviewing files that changed from the base of the PR and between eaadc20 and c8df791.

📒 Files selected for processing (1)
  • django/thunderstore/repository/admin/package.py

Walkthrough

The changes add a new PackageListingInline class to the package admin module, enabling inline management of PackageListing records within the PackageAdmin interface. The inline is configured as a tabular display showing only the community field, with permissions set to allow additions while preventing modification or deletion of existing listings. This integrates the new inline into the existing PackageAdmin composition without altering core deprecation logic.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding PackageListingInline to Django Admin for managing package listings across communities.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding PackageListingInline for listing packages to new communities via Django Admin.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (1964bb4) to head (c8df791).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
+ Coverage   93.03%   93.10%   +0.06%     
==========================================
  Files         344      344              
  Lines       10639    10747     +108     
  Branches      954      968      +14     
==========================================
+ Hits         9898    10006     +108     
- Misses        617      618       +1     
+ Partials      124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant