Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions django/thunderstore/api/cyberstorm/services/package_listing.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@ def report_package_listing(
) -> None:
user = validate_user(agent)

existing_reports = PackageReport.objects.filter(
submitted_by=user,
package_listing=package_listing,
is_automated=False,
is_active=True,
)

if existing_reports.exists() and not user.is_superuser:
error_msg = "You have already reported this package listing"
raise PermissionValidationError(error_msg)

PackageReport.handle_user_report(
reason=reason,
submitted_by=user,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
from thunderstore.api.cyberstorm.services.package_listing import (
approve_package_listing,
reject_package_listing,
report_package_listing,
unlist_package_listing,
update_categories,
)
from thunderstore.community.consts import PackageListingReviewStatus
from thunderstore.core.exceptions import PermissionValidationError
from thunderstore.ts_reports.models import PackageReport


@pytest.mark.django_db
Expand Down Expand Up @@ -172,3 +174,57 @@ def test_unlist_package_listing(active_package_listing, user_role, can_unlist):
with pytest.raises(PermissionValidationError):
unlist_package_listing(agent=agent, listing=active_package_listing)
assert active_package_listing.package.is_active is True


@pytest.mark.django_db
def test_report_package_listing_success(user, active_package_listing):
report_package_listing(
agent=user,
reason="Inappropriate content",
package=active_package_listing.package,
package_listing=active_package_listing,
package_version=active_package_listing.package.latest,
description="This package contains inappropriate content.",
)

assert (
PackageReport.objects.filter(
submitted_by=user,
package_listing=active_package_listing,
is_automated=False,
is_active=True,
).count()
== 1
)


@pytest.mark.django_db
def test_report_package_listing_report_limit(user, active_package_listing):
report_package_listing(
agent=user,
reason="Inappropriate content",
package=active_package_listing.package,
package_listing=active_package_listing,
package_version=active_package_listing.package.latest,
description="This package contains inappropriate content.",
)

with pytest.raises(PermissionValidationError):
report_package_listing(
agent=user,
reason="Spam",
package=active_package_listing.package,
package_listing=active_package_listing,
package_version=active_package_listing.package.latest,
description="This package is spam.",
)

assert (
PackageReport.objects.filter(
submitted_by=user,
package_listing=active_package_listing,
is_automated=False,
is_active=True,
).count()
== 1
)
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,24 @@ def test_unlist_package_listing(
data={},
expected_status_code_map=expected_status_code_map,
)


@pytest.mark.django_db
def test_report_package_listing_limit(
api_client: APIClient, active_package_listing: PackageListing
):
"""Test that users cannot report the same package listing multiple times."""

user = TestUserTypes.get_user_by_type(TestUserTypes.regular_user)
api_client.force_authenticate(user=user)
url = get_report_url(active_package_listing)

data = json.dumps({"reason": "Spam"})
response = api_client.post(url, data=data, content_type="application/json")
assert response.status_code == 200

response = api_client.post(url, data=data, content_type="application/json")
error_msg = "You have already reported this package listing"

assert response.status_code == 403
assert response.json() == {"non_field_errors": [error_msg]}
Loading