Open
Conversation
davinotdavid
approved these changes
Apr 15, 2026
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
lgtm, thanks for the cleanup! one comment:
| lock: lockNotification, | ||
| } = siteNotificationStore; | ||
| provide(accountsTbProfileUrlKey, import.meta.env.VITE_TB_ACCOUNT_DASHBOARD_URL); |
Contributor
There was a problem hiding this comment.
I think we should instead have the users of VITE_TB_ACCOUNT_DASHBOARD_URL use the inject / key so that in the odd case that its content changes, we don't have to change in all places.
For example:
We can punt this to another ticket though!
(Also VITE_SUPPORT_URL is being used a lot more throughout the codebase so we should probably punt it into a provide / inject key as well)
Collaborator
Author
There was a problem hiding this comment.
Great suggestion, thanks so much! I added provides/injects directly for the following constants now:
VITE_TB_ACCOUNT_DASHBOARD_URLVITE_TB_PRO_URLVITE_SUPPORT_URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This is a maintenance change and contains code removal only. No functionality was changed.
Why?
Lighter frontend code base.
Limitations and Notes
I focused on unused exports and provides at root level. There might be more unused code in specific components.
Applicable Issues
Closes #1609