-
Notifications
You must be signed in to change notification settings - Fork 18
Add Flower alongside live environment Celery workers #1617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f967bdb
Install flower for local dev; add explicit 'api' CONTAINER_ROLE
ryanjjung 07b980f
Upgrade tb_pulumi, restructure dev task definitions
ryanjjung c8a6941
Build new log destination and cluster in dev
ryanjjung df37314
Allow Celery and Flower containers to speak to Redis
ryanjjung 7fae63b
Merge branch 'main' into celery-infra
ryanjjung 8c93efa
Use alternate Flower port in local dev to avoid port collisions
ryanjjung fb419bf
Update stage task/container defs
ryanjjung 8b7f412
Fix IP and cert in dev; build celery/flower cluster in stage
ryanjjung 6900277
Add portMappings, scale flower down, update stage deployment flow
ryanjjung a4bba21
Update prod config for new cluster; update deploy workflows
ryanjjung f583dee
Update stage image
ryanjjung 0b23beb
Tear down bastion
ryanjjung 94a1d1b
Enable unauthenticated Flower API
ryanjjung 0642c12
Fix environment name in deploy
ryanjjung 8b410b8
Fix celery role names
ryanjjung c78ef57
Add local dev CONTAINER_ROLE for api
ryanjjung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ services: | |
| - ./backend/.env:/app/.env | ||
| - ./backend/src/appointment:/app/appointment | ||
| environment: | ||
| - CONTAINER_ROLE=api | ||
| - IS_LOCAL_DEV=yes | ||
| - RELEASE_VERSION=localdev | ||
| extra_hosts: | ||
|
|
@@ -36,6 +37,17 @@ services: | |
| - backend | ||
| - redis | ||
|
|
||
| celery-flower: | ||
| <<: *backend | ||
| ports: | ||
| - 5556:5555 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Davi requested this port exposure change so that this does not conflict with a simultaneously running Flower container for a local dev instance of Accounts. |
||
| environment: | ||
| - CONTAINER_ROLE=flower | ||
| - FLOWER_UNAUTHENTICATED_API=true | ||
| depends_on: | ||
| - backend | ||
| - redis | ||
|
|
||
| frontend: | ||
| build: ./frontend | ||
| volumes: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is simpler now due to the DRYing out of the task definitions.