Fix: Prevent custom connectors from colliding#2117
Open
ecoutier wants to merge 1 commit intothingsboard:masterfrom
Open
Fix: Prevent custom connectors from colliding#2117ecoutier wants to merge 1 commit intothingsboard:masterfrom
ecoutier wants to merge 1 commit intothingsboard:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR is linked to the feature request I mentioned in the discord server.
When using remote config with multiple custom connectors of the same type, only the last one was ever instantiated. This is because
_implemented_connectorswas keyed byconnector_type, so each new connector of the same type would silently overwrite the previous entry:I may not have the full context on why it was originally designed this way, happy to get feedback or alternative approaches if there's a reason I'm missing.
Changes
_implemented_connectorsis now keyed by connector name instead of connector type, both at registration (_load_connectors) and at lookup (__connect_with_connectors,__init_and_start_regular_connector). Since names are supposedly unique per connector instance, multiple custom connectors of the same type can now coexist.Impact
This is a workaround pending proper multi-custom-connector support in the UI.
This has worked on my part to be able to have 2 different custom connectors at the same time, with 2 different classes.
Please note that RPC calls have not been tested
Only covers the remote config scenario : for non remote config, it is still possible to have a folder per custom connector.