Skip to content

make sure getters always return Symbols #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomasc wants to merge 8 commits into
base: master
Choose a base branch
from
Open

make sure getters always return Symbols #30

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bec99d6
Update enum.rb
tomasc Dec 11, 2015
12ed93e
array accessor converts to_sym as well
tomasc Dec 11, 2015
de50b88
use send rather than read_attribute
tomasc Dec 16, 2015
0db167f
fix travis
tomasc Feb 14, 2016
cfb12c3
Update enum.rb
tomasc Feb 24, 2016
4368a48
Validations
Feb 24, 2016
d2f3b9f
Relax Mongoid dependency
tomasc Mar 12, 2016
5f1dc6a
Update mongoid-enum.gemspec
tomasc Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/mongoid/enum.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ def define_field_accessor(name, field_name, options)

def define_array_field_accessor(name, field_name)
class_eval "def #{name}=(vals) self.write_attribute(:#{field_name}, Array(vals).compact.map(&:to_sym)) end"
class_eval "def #{name}() self.read_attribute(:#{field_name}) end"
class_eval "def #{name}() self.send(:#{field_name}).map{ |i| i.try(:to_sym) } end"

@houndci-bot houndci-bot Dec 16, 2015

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [90/80]

end

def define_string_field_accessor(name, field_name)
class_eval "def #{name}=(val) self.write_attribute(:#{field_name}, val && val.to_sym || nil) end"
class_eval "def #{name}() self.read_attribute(:#{field_name}) end"
class_eval "def #{name}() self.send(:#{field_name}) end"
end

def define_array_accessor(field_name, value)
Expand Down