Skip to content

Keep reference to named routes instead of moving the route to a different array. Fixes #362 - #363

Merged
philipobenito merged 4 commits into
thephpleague:7.xfrom
mlgpuntnl:named-routes-order
Jul 14, 2026
Merged

philipobenito merged 4 commits into
thephpleague:7.xfrom
mlgpuntnl:named-routes-order

Conversation

@mlgpuntnl

Copy link
Copy Markdown
Contributor

No description provided.

@philipobenito philipobenito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nitpicks commented, and would be nice to have a regression test for this, but otherwise thanks for finding and fixing

Comment thread src/Router.php Outdated
Comment thread src/Router.php Outdated
@philipobenito

Copy link
Copy Markdown
Member

Perfect, thanks @mlgpuntnl I'll get it merged in this weekend, I still need a little more testing of the whole of 7.x before tagging though, your feedback is welcome if you're actively using it.

@sllide

sllide commented Jul 3, 2026

Copy link
Copy Markdown

my man, where is the merge

@philipobenito

Copy link
Copy Markdown
Member

sorry about that @sllide - completely slipped my mind, will get to it this week

@philipobenito
philipobenito merged commit cd257e6 into thephpleague:7.x Jul 14, 2026
5 checks passed
@mlgpuntnl
mlgpuntnl deleted the named-routes-order branch July 15, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants