You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feature: addition of the ZipArchive adapter - #202
I'm afraid it's not that simple :/ We also need to inject the FilesystemZipArchiveProvider which must provide the path to zip that, which can't be resolved at compile time.
The design between ZipAdapter and FilesystemZipArchiveProvider in this state is not suitable for our integration because the FilesystemZipArchiveProvider sets the path to the zip file for the entire set only the in the zip can be set at runtime.
If you find a way to do, I would be glad to review it.
@maxhelias
I see what you mean by diving into it more deeply. It already felt too easy to do it this way, my apologies for assuming instead of researching.
Gotta say, the entire design of the (Filesystem)ZipArchiveProvider feels weird and needs a major overhaul for it to work in this bundle indeed.
I'm closing this as I don't see an easy fix/change that won't impact the Provider greatly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help with:
#201