Repository navigation
Respect ID in heading with HeadingPermalinkExtension - #1160
Merged
colinodell merged 2 commits intoOct 17, 2026
Merged
Conversation
ChloeSartorelli
added a commit
to creative-commoners/silverstripe-userdocs-admin
that referenced
this pull request
Oct 6, 2026
Relies on github.com/thephpleague/commonmark/pull/1160 for custom anchors in headings
Contributor
Author
|
CI failures are unrelated to this PR |
If the AttributesExtension applies an ID to a heading, and the HeadingPermalinkExtension would normally add the ID to the heading, respect the ID from the AttributesExtension instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
colinodell
force-pushed
the
pulls/2.10/heading-ids
branch
from
October 17, 2026 19:55
f2158dd to
0ae19e3
Compare
colinodell
enabled auto-merge (squash)
October 17, 2026 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
AttributesExtensionapplies an ID to a heading, and theHeadingPermalinkExtensionwould normally add the ID to the heading, respect the ID from theAttributesExtensioninstead.I've opted to still add the id and anchor prefixes, as it seems appropriate to respect those settings.
Fixes #1159
I don't know what the "lowest maintained branch" that this applies to is. If you'd like me to retarget this to a specific branch please let me know.