chore: drop unused generated code - #2714
Open
golanglemonade wants to merge 5 commits into
Open
Conversation
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
golanglemonade
force-pushed
the
feat-drop-unusued-code
branch
from
August 20, 2026 16:57
c5078fa to
bd66965
Compare
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


tl;dr: Cleans up over 250k lines of unused code; mostly in history generated code;
historyschemato now have the below; which will then drop allUpdatecode from generation (see the 45k lines of code removed frominternal/graphapi/generated/ent.generated.goFeatureSchemaConfigfeature in ent we turned on but never used; removedgen.FeatureModifierfrom history generation inentc.gointernal/ent/generate/templates/entgql/gql_where.tmplchangesinternal/ent/privacy/rule/allow_mutation_valid_signup_token.goandinternal/ent/privacy/rule/deny_questionnaire.goprivacy/rule/tokeninternal/ent/validator/graphql_filter_validator.goImplementAllDirectivefunctions out ofinternal/graphapi/directives/directives.gointo thegraphapipackage to prevent not-fun times on code generation due to deps on the graphapi generated fileswithopts ininternal/httpserve/route/router.go