Refactor angle force constant formula and add test suite#7
Open
Eashan-H wants to merge 2 commits intotheochem:mainfrom
Open
Refactor angle force constant formula and add test suite#7Eashan-H wants to merge 2 commits intotheochem:mainfrom
Eashan-H wants to merge 2 commits intotheochem:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the get_angle_force_constant method in ffprime/bond.py to strictly adhere to the standard Seminario (1996) method. The previous
implementation produced physically unrealistic values (~2500 kcal/mol/rad²) due to squared eigenvalue analysis and incorrect unit scaling. The corrected
code now yields standard molecular mechanics values (~10–25 kcal/mol/rad²) that match established literature results.
Physical & Mathematical Rationale
The derivation follows the Seminario method for calculating harmonic force constants directly from the QM Hessian. The core logic was updated to address
three critical issues:
3$ Hessian blocks (
squared weights, as specified in the original paper.
the harmonic mean of the projected Cartesian stiffness:
where
Changes
Verification Results
The implementation was verified using the provided examples/lig.log and lig.fchk files:
Closes : Bug: Physically unrealistic angle force constants in get_angle_force_constant #6