This repository was archived by the owner on Nov 9, 2026. It is now read-only.
Repository navigation
Conversation
The test could close its link while the next reconnect was still in its handshake. The ws library reports that as an 'error' event and throws when nothing listens, and the page's close() takes its handlers off first. A browser's WebSocket just closes, so the page's code stays as it is and the test's WebSocket always has a listener. Run 48 times under load, the file failed 3 times before and none after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
net-trouble.test.mjsfailed now and then on CI (seen on #138) withWebSocket was closed before the connection was established.The test could close its link while the next reconnect was still in its handshake. The
wslibrary reports that as an'error'event and throws when nothing listens, and the page'sclose()takes its handlers off first.What changes
The test's WebSocket always has an
'error'listener. A browser's WebSocket just closes in this case, so the page's code stays as it is. Test only.Testing
The whole test file, run 48 times under load (12 at once):
🤖 Generated with Claude Code