add: ncspot#10701
Conversation
![hamachitan[bot]](https://avatars.githubusercontent.com/u/252208892?s=60&v=4){kind=small}
Co-authored-by: hamachitan[bot] <252235638+hamachitan[bot]@users.noreply.github.com> Signed-off-by: Engels Tercero <75184282+like-engels@users.noreply.github.com>
| Requires: dbus | ||
| Requires: glibc | ||
| Requires: libxcb | ||
| Requires: pipewire-pulseaudio | ||
| Requires: pulseaudio-libs | ||
| Requires: openssl | ||
|
|
There was a problem hiding this comment.
if you have specified the buildrequires you don't need to specify these
There was a problem hiding this comment.
Some of them are runtime dependencies (such as the pulseaudio libs) that's why I explicitly added them as package dependencies.
I'm not an RPM expert so I'd appreciate some guidance on this, because runtime dependencies are what I'm concerned about.
There was a problem hiding this comment.
so basically at the end of the build RPM will look at what the binary dynamically links to and add all these runtime requirements automatically, including information about the sover (that is the ABI version).
The only case where you need to manually add these runtime dependencies would be when the binary needs these runtime dependencies but it's not dynamically linked to them. As an example, if I create a program that runs the sed program, then I need to add sed as a runtime dependency when I package the program into an RPM.
|
I just looked at the repository, seems like there's an xtask that can generate manpages and shell completions, do you know how to add that to the package? |
|
@madonuko Hi Madonuko, sadly I don't know how I could integrate it alongside the build system. :( |
Head branch was pushed to by a user without write access
| Packager: like-engels <higashikataengels@icloud.com> | ||
| License: BSD-2-Clause AND (MIT OR Apache-2.0) | ||
| URL: https://crates.io/crates/%{crate} | ||
| Source0: %{crates_source} |
There was a problem hiding this comment.
| Source0: %{crates_source} | |
| Source0: https://github.com/hrkfdn/ncspot/archive/refs/tags/v%version.tar.gz |
| %license LICENSE | ||
| %license LICENSE.dependencies | ||
| %doc README.md | ||
| %{_bindir}/%{crate} |
There was a problem hiding this comment.
| %{_bindir}/%{crate} | |
| %{_bindir}/%{crate} | |
| %{_appsdir}/%{crate}.desktop | |
| %{_mandir}/man1/*.1.gz |
There was a problem hiding this comment.
This is a CLI tool, so I'll skip the desktop file
| %{cargo_license_online} > LICENSE.dependencies | ||
|
|
||
| %install | ||
| %crate_install_bin |
There was a problem hiding this comment.
| %crate_install_bin | |
| %crate_install_bin | |
| cargo xtask generate-manpage | |
| cargo xtask generate-shell-completion | |
| install -Dpm644 misc/%{crate}.desktop -t %buildroot%_appsdir | |
| install -Dm644 misc/*.1 -t %buildroot%_mandir/man1 | |
| install -Dm755 misc/%{crate}.bash -t %buildroot%bash_completions_dir | |
| install -Dm755 misc/%{crate}.elv -t %buildroot%elvish_completions_dir | |
| install -Dm755 misc/%{crate}.fish -t %buildroot%fish_completions_dir | |
| install -Dm755 misc/_%{crate} -t %buildroot%zsh_completions_dir |
| official Spotify client.} | ||
|
|
||
| %description %{_description} | ||
|
|
There was a problem hiding this comment.
| %pkg_completion -befz | |
|
@like-engels are you able to try Mado's suggestions? |
3 participants
I wanted to contribute an RPM version of ncspot so we can play our bangers from terminal, since this is a very popular and nice Spotify TUI and there's no repo listing for Fedora/RHEL and derivatives I think we could also get in touch with the maintainer to list Terra as an RPM repo for it.
I built this locally and it works great on RHEL 10 & Fedora 43