Repository navigation
feat: add MACH funding entrypoints across wallet transports - #859
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Contributor
|
Contributor
|
## Summary Add optional `destinationToken` to the `wallet_deposit` request schema. Preserve the existing `token` source hint and requests that omit the new parameter. Document runtime wallet-support discovery and include a minor changeset. This companion is stacked on [accounts #859](#859), the SDK branch already pinned by Tempo Wallet. Its diff contains only the destination parameter, its schema/type coverage, and destination-aware dismissal cases; it does not change MACH or other funding behavior. ## Validation - 25 request-schema tests pass, including preservation of both source and destination hints and existing omitted-parameter coverage. - Four transport dismissal tests pass for omitted and OUSD destinations, including a wallet that ignores cancellation. These in-process cases ran with a temporary configuration without localnet setup; other localnet cases were not run. - SDK TypeScript project checks pass (`pnpm exec tsc -b --noEmit`). Prompted by: @danrobinson Co-authored-by: Daniel Robinson <1187252+danrobinson@users.noreply.github.com>
Contributor
|
Contributor
|
gakonst
added a commit
to tempoxyz/wallet-cli
that referenced
this pull request
Oct 6, 2026
Make MACH the default funding path and replace Coinflow credit payments with canonical onchain MACH settlement. `tempo wallet fund --amount 5 --no-browser --no-wait` returns a recipient-bound checkout link for remote agents. Normal funding opens the same link and waits, with a deadline and cancellation, for the requested MACH balance increase. `whoami --mach` reads the six-decimal token balance. `request --mach --max-spend ...` and challenge-based `transfer --mach` use mppx with strict caps, challenge validation, and no stablecoin fallback when MACH is explicitly selected. Paid requests and uncertain settlements are not retried. Dry runs inspect the quote without signing or requiring a budget. Deprecated `--credits` spellings warn and select MACH; old offchain credits are neither redeemed nor converted. Validation: all 59 focused tests pass, including the real SDK with mocked RPC/signing. The full suite, source/test TypeScript, code checks, and package build pass. CI Tests, Types, Code and Check passed at cab7495; the follow-up commit adds the required release note. Local full-suite testing used one worker and a 60-second timeout because unchanged-base CLI startup took 10.39 seconds on the loaded Mac (this branch took 9.85 seconds). No real signing or payments were performed. Checkout links require the companion wallet web deployment. Hosted checkout currently supports mainnet, $5-$100 with cent precision. Balance queries also recognize the testnet token deployment. Balance polling observes funding; it does not prove a particular card charge. Related SDK: tempoxyz/accounts#859. Web wallet and Rust CLI use the same funding-link contract. Companion hosted MACH checkout and CLI key permissions: tempoxyz/wallet#789.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add one MACH funding entry point for apps, mobile adapters, and CLI callers.
Mach.fund(provider, hints)openswallet_depositwith the mainnet MACH token.Mach.getFundingUrl({ address, amount })produces a recipient-bound wallet link for callers that cannot mount the wallet UI. Both validate recipient, chain, and amount before handing off.Post-connect and access-key deposit hints now carry
intent: 'mach'. Documentation covers direct requests and transport-independent links. Legacy offchain MPP Credits remain a separate balance; opening checkout does not prove funds arrived.Validation: 619 pure tests pass, including 23 MACH/intent tests; TypeScript/type tests, package and documentation builds pass. Lint/format checks pass with two pre-existing unrelated warnings. CI runtime/localnet, package builds, hosted documentation preview and both playgrounds pass.
CI Verify / Checks remains blocked by the pre-existing
braces@3.0.3audit finding GHSA-vfj7-8cjw-p6xm. Package manifests and the lockfile are unchanged in this PR, and the vulnerable version is present in its base commit. As checked on October 5, the upstream advisory lists no patched version;braces@3.0.4is not published. The audit policy remains enabled.Requires the companion wallet checkout implementation and MACH service binding before advertising the SDK helper. Related TypeScript CLI: tempoxyz/wallet-cli#166.
Companion hosted MACH checkout and CLI key permissions: https://github.com/tempoxyz/wallet/pull/789.