refactor(DT-3906): UI Svelte 5 Migrations medium#3368
Merged
tegan-temporal merged 6 commits intocodefreeze-05.01.26from May 7, 2026
Merged
refactor(DT-3906): UI Svelte 5 Migrations medium#3368tegan-temporal merged 6 commits intocodefreeze-05.01.26from
tegan-temporal merged 6 commits intocodefreeze-05.01.26from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
tegan-temporal
changed the base branch from
codefreeze-05.01.26
to
DT-3906-ui-svelte-5-migrate-trivial
Base automatically changed from
DT-3906-ui-svelte-5-migrate-trivial
to
codefreeze-05.01.26
May 7, 2026 15:23
tegan-temporal
force-pushed
the
DT-3906-ui-svelte-5-migrate-medium
branch
from
c005eb3 to
d742777
Compare
laurakwhit
reviewed
May 7, 2026
| $: _value = value; | ||
|
|
||
| let isValid = true; | ||
| let _value = $derived($filter.value); |
Collaborator
There was a problem hiding this comment.
I don't think we can bind a derived value. I think we might need something like this 🤔
Suggested change
| let _value = $derived($filter.value); | |
| let _value = $state($filter.value); | |
| $effect(() => { | |
| _value = $filter.value; | |
| }); |
Collaborator
There was a problem hiding this comment.
Just seeing your comment r.e. overriding derived values 👀 And testing it out it seems to work ✅
laurakwhit
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
A collection of svelte 5 migrations