Cleanly stop inbound streams during shutdown.#9983
Open
robholland wants to merge 6 commits intotemporalio:mainfrom
Open
Cleanly stop inbound streams during shutdown.#9983robholland wants to merge 6 commits intotemporalio:mainfrom
robholland wants to merge 6 commits intotemporalio:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit b887cf5. Configure here.
michaely520
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed?
When gracefully shutting down, close inbound streams, not just outbound.
Why?
This avoids unexpected connection reset on the sender side.
Flag enabled (default — new behavior):
replicationTaskFetcherFactory, shardController, eventNotifier
Flag disabled (current behavior):
How did you test it?
Note
Medium Risk
Touches history service shutdown sequencing and replication stream lifecycle, which can affect rolling restarts and cross-cluster replication behavior if the new ordering has unintended side effects.
Overview
Improves history service graceful shutdown by optionally closing inbound replication streams (in addition to outbound) so remote senders are signaled to stop and stream handler goroutines can drain cleanly.
Introduces new dynamic config
history.enableCloseInboundReplicationStreamOnShutdown(defaulttrue), threads it through historyConfig, and uses it to (a) stop inbound streams inStreamReceiverMonitor.Stop()and (b) reorderservice.goshutdown to callhandler.Stop()beforeserver.GracefulStop()when enabled; adds unit tests covering both enabled/disabled behaviors.Reviewed by Cursor Bugbot for commit 8aab9ee. Bugbot is set up for automated code reviews on this repo. Configure here.