-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use principal to classify system workers #10143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rkannan82
wants to merge
26
commits into
main
Choose a base branch
from
kannan/system-worker-principal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+127
−53
Open
Changes from 14 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
bb96ab1
Exclude system workers from ListWorkers by default
rkannan82 ded6b71
Add unit test for system worker filtering in ListWorkers
rkannan82 4cce906
Also exclude /temporal-sys/ path-style task queues (worker-commands)
rkannan82 7feb2df
Revert "Also exclude /temporal-sys/ path-style task queues (worker-co…
rkannan82 d360bfb
Add pagination test for system worker filtering
rkannan82 093da36
Simplify pagination test to explicit per-page assertions
rkannan82 769af51
Merge branch 'main' into kannan/list-workers-exclude-system
rkannan82 5cce93d
Store isSystemWorker at upsert time instead of checking task queue na…
rkannan82 35df1fb
Rename isSystem to isSystemWorker and add filterWorkers test coverage
rkannan82 d7bfe94
Merge branch 'main' into kannan/list-workers-exclude-system
rkannan82 6342296
Bump go.temporal.io/api to pick up include_system_workers field
rkannan82 8ef1141
Fix isSystemWorkerWorker typo in entry struct
rkannan82 1ae9010
Use principal to classify system workers with task queue prefix fallback
rkannan82 30a8a36
Check both principal type and name for system worker classification
rkannan82 63af273
Fix import ordering and whitespace formatting
rkannan82 95bf65c
Merge branch 'main' into kannan/list-workers-exclude-system
rkannan82 3473528
Merge remote-tracking branch 'origin/main' into kannan/list-workers-e…
rkannan82 0450481
Fix comment spacing in test file
rkannan82 cbb8611
Merge remote-tracking branch 'origin/kannan/list-workers-exclude-syst…
rkannan82 7ff6ef0
Merge remote-tracking branch 'origin/main' into kannan/system-worker-…
rkannan82 8c0ce17
Fix comment spacing in registry_test.go
rkannan82 98df0cb
Fix comment spacing and extra blank line in tests
rkannan82 5dcd1f5
Rename isSystemPrincipal to isSystemWorker
rkannan82 382b850
Rename TestIsSystemPrincipal to TestIsSystemWorker
rkannan82 ad52b6a
Fix import grouping (gci)
rkannan82 2531b86
Fix import grouping (gci)
rkannan82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.