Exclude system workers from ListWorkers by default#10132
Merged
Conversation
System workers (on temporal-sys-* task queues) are now filtered out of ListWorkers responses unless the caller sets IncludeSystemWorkers=true. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers both "temporal-sys-*" (e.g. temporal-sys-per-ns-tq) and "/temporal-sys/*" (e.g. /temporal-sys/worker-commands/...) prefixes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mmands)" This reverts commit 4cce906.
Verifies that page sizes and tokens operate on the filtered set, not the full set including system workers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…me at query time Moves the system worker classification to the entry level so it's computed once during heartbeat recording rather than on every ListWorkers call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename local variable for clarity - Add test for filterWorkers with includeSystemWorkers=false - Annotate bool args with /*includeSystemWorkers*/ for readability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Note: this introduces a build failure in client/frontend due to the new PauseActivityExecution RPC added in temporalio/api#743. That method needs stubs before the full repo can build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ShahabT
approved these changes
May 1, 2026
…xclude-system # Conflicts: # common/primitives/task_queues.go
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exclude internal system workers from ListWorkers API results by default. Users can opt in to seeing them via
include_system_workerson the request.Depends on API change: temporalio/api#777
Why
System workers (per-namespace workers for scheduler, batcher, worker deployment, etc.) appear in ListWorkers results, which is confusing for users who only care about their own workers.
How did you test it?
Unit tests.
🤖 Generated with Claude Code