fix: Addresses missed feedback for PR 10020#10087
Merged
davidporter-id-au merged 3 commits intotemporalio:mainfrom Apr 27, 2026
Merged
Conversation
davidporter-id-au
changed the title
| "go.temporal.io/server/api/historyservice/v1" | ||
| "go.temporal.io/server/chasm" | ||
| activitypb "go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1" | ||
| "go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1" |
Contributor
Author
There was a problem hiding this comment.
honestly didn't know about this feature of import aliasing in go
fretz12
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This is some fast-follow feedback items for the PR #10020.
Why?
Automerge landed the changes before I could respond, so just adding these followup items here.
How did you test it?
Potential risks
small test changes only, very low risk