Draft
Conversation
24923a8 to
1e06e05
Compare
1e06e05 to
eb1bde8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR prototypes an experimental API development flow without long-lived Temporal feature branches.
It adds:
frontend.apiVariantapi-gomodules for additive RPCs (ping,tinker)fairness)Why?
Developing in-progress APIs across
api,api-go, andtemporalcurrently requires feature branches, repeated rebases, and a large final merge. This change explores a smaller incremental path where Temporal can depend on temporary experimentalapi-gomodules until the stable API lands.How did you test it?
Local verification included:
go test ./cmd/experimentgeninapi-gogo test ./...in the generatedping,tinker, andfairnessexperiment modulesgo test -tags 'test_dep experimental' ./service/frontend/servicesgo test -tags 'test_dep experimental' ./tests/testcore ./tests -run 'TestExperimentalApi_(Ping|Tinker|Stable|FairnessWrapper)'go test -c -o /dev/null ./tests -tags 'disable_grpc_modules,test_dep,experimental'make fmt-importsmake lint-codePotential risks
This is prototype-only infrastructure and increases complexity in frontend registration, test wiring, and module generation. The wrapper path intentionally relies on protobuf unknown fields, so it is best suited to additive field experiments and should stay temporary until the stable API is merged.