Schedule: support ScheduleSpec.rrule (RRULE) for calendar recurrence#10067
Open
wei-hai-clickup wants to merge 2 commits intotemporalio:mainfrom
Open
Schedule: support ScheduleSpec.rrule (RRULE) for calendar recurrence#10067wei-hai-clickup wants to merge 2 commits intotemporalio:mainfrom
wei-hai-clickup wants to merge 2 commits intotemporalio:mainfrom
Conversation
…ezones When interval is a multiple of 86400s and the schedule has a non-UTC location, advance by whole calendar days at a fixed local time of day (DST-aware) instead of fixed 86400s in UTC. UTC schedules keep the previous Unix-math behavior. See temporalio#10058. Made-with: Cursor
- Parse RFC 5545 rules after canonicalization; DTSTART from start_time or epoch in zone - rawNextTime unions rrule next times with calendar and interval - go.mod replace go.temporal.io/api with github.com/wei-hai-clickup/temporal-go-api-rrule@d3838e until api merges Closes the RRULE path discussed in temporalio#10058. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements temporal#10058: compile
ScheduleSpec.rrulewith teambition/rrule-go and take the min next time alongside calendar and interval.Dependencies
go.temporal.io/apiwithrepeated string rruleonScheduleSpec(see temporalio/api#773).replaceingo.modpointing at wei-hai-clickup/temporal-go-api-rrule@d3838e (full module with generatedmessage.pb.go).After api merges: drop the
replace,go getthe newgo.temporal.io/apiversion, and remove the temporary mirror repo if desired.Civil 24h intervals: existing behavior on
fix/interval-spec-civil-day-dstremains compatible (this branch is RRULE-only).Made with Cursor