fix: mark idempotent CQL queries for driver-level retry on write timeouts#10050
Open
mykaul wants to merge 1 commit intotemporalio:mainfrom
Open
fix: mark idempotent CQL queries for driver-level retry on write timeouts#10050mykaul wants to merge 1 commit intotemporalio:mainfrom
mykaul wants to merge 1 commit intotemporalio:mainfrom
Conversation
…outs Pure reads (SELECT) and unconditional writes (INSERT/DELETE without IF conditions) are now marked with .Idempotent(true) so the gocql driver retries them on write timeouts instead of returning Rethrow. LWT/CAS queries are intentionally left unmarked since retrying them could violate correctness. Tested with omes throughput_stress against both Cassandra 5.0 and ScyllaDB 2025.4 with no regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.Idempotent(true)across all 13 Cassandra persistence store files.WriteTimeoutErrorinstead of returningRethrow, reducing transient error propagation to the application layer.Motivation
Both Cassandra and ScyllaDB can return write timeouts under load. Without the idempotent flag, the driver's
OnWriteTimeouthandler returnsRethrow, forcing expensive application-level retries (full persistence operation replay, context re-creation). Driver-level retry is significantly cheaper and handles the common transient timeout case transparently.Testing
throughput_stressagainst both Cassandra 5.0 and ScyllaDB 2025.4 with no regressions.