Refactor sync match results to be returned as structs for readability#10044
Open
rkannan82 wants to merge 4 commits intokannan/fix-forwarded-task-hook-double-firefrom
Open
Refactor sync match results to be returned as structs for readability#10044rkannan82 wants to merge 4 commits intokannan/fix-forwarded-task-hook-double-firefrom
rkannan82 wants to merge 4 commits intokannan/fix-forwarded-task-hook-double-firefrom
Conversation
Purely mechanical change — wraps multiple return values in named structs for readability with no behavior change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps the return values of
TrySyncMatch,MatchTaskImmediatelyin named structs.Why
Improves readability. We have a follow up PR that adds a rate limited bool to it.
How did you test it?
Existing unit tests.
🤖 Generated with Claude Code