Skip to content

Nexus Operations request side metrics#10033

Open
S15 wants to merge 1 commit intomainfrom
nexus-request-metrics
Open

Nexus Operations request side metrics#10033
S15 wants to merge 1 commit intomainfrom
nexus-request-metrics

Conversation

@S15
Copy link
Copy Markdown
Contributor

@S15 S15 commented Apr 22, 2026

What changed?

New Metrics:

Counters

Metric Description
nexus_request_error_count Nexus requests that result in an error

New Labels:

For nexus_requests, nexus_request_error_count and nexus_latency. Most of these were already set on nexus_requests and nexus_latency

Label Notes
namespace
nexus_endpoint
nexus_service Controlled by Dynamic config
nexus_operation Controlled by Dynamic config
nexus_caller
nexus_caller_type Currently always "namespace"

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@S15
Copy link
Copy Markdown
Contributor Author

S15 commented Apr 22, 2026

Notes:
Waiting to hear back from @kepe-temporal on if we need to change the names of nexus_requests and nexus_latency.

Test failures are shared with feature/nexus-standalone branch.

callerInfo := headers.GetCallerInfo(ctx)
tags = append(tags, metrics.NexusCallerTag(callerInfo.CallerName))
// Namespace is the only valid caller_type. To be updated when there are more kinds
tags = append(tags, metrics.NexusCallerTypeTag("namespace"))
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a better way to do this. callerInfo.CallerType seems to be something else (which is maybe a hint that using callerInfo at all is wrong here?).

@S15 S15 marked this pull request as ready for review April 22, 2026 21:56
@S15 S15 requested review from a team as code owners April 22, 2026 21:56
@S15 S15 requested review from bergundy and stephanos April 22, 2026 21:56
@bergundy
Copy link
Copy Markdown
Member

Not reviewing this yet since we have all of the metrics in different forms already. Let's see what @kepe-temporal comes back with.

@stephanos stephanos force-pushed the feature/nexus-standalone branch from 38923fc to 340f40a Compare April 23, 2026 17:11
@stephanos stephanos requested a review from a team as a code owner April 23, 2026 17:11
@stephanos stephanos force-pushed the feature/nexus-standalone branch from 7ae0421 to 414a003 Compare April 23, 2026 19:09
@stephanos stephanos requested review from a team as code owners April 23, 2026 19:09
@stephanos stephanos force-pushed the feature/nexus-standalone branch 3 times, most recently from ce242b7 to 397eca3 Compare April 23, 2026 20:21
@S15 S15 force-pushed the feature/nexus-standalone branch from 397eca3 to 7ae0421 Compare April 23, 2026 20:35
@stephanos stephanos force-pushed the feature/nexus-standalone branch 2 times, most recently from e36b74b to bcda346 Compare April 23, 2026 21:01
@kepe-temporal
Copy link
Copy Markdown
Contributor

We can use the old metrics and rename them, but we can't split metrics across multiple tables on ingest depending on the value of a label.

@stephanos stephanos force-pushed the feature/nexus-standalone branch 9 times, most recently from a44e612 to 44d2c2b Compare April 23, 2026 23:05
@stephanos stephanos force-pushed the feature/nexus-standalone branch 10 times, most recently from 378e20c to 80b781d Compare April 24, 2026 04:25
Base automatically changed from feature/nexus-standalone to main April 24, 2026 05:49
@S15 S15 force-pushed the nexus-request-metrics branch from 6075a82 to 1c9aa39 Compare April 24, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants