Open
Conversation
Contributor
Author
|
Notes: Test failures are shared with |
S15
commented
Apr 22, 2026
| callerInfo := headers.GetCallerInfo(ctx) | ||
| tags = append(tags, metrics.NexusCallerTag(callerInfo.CallerName)) | ||
| // Namespace is the only valid caller_type. To be updated when there are more kinds | ||
| tags = append(tags, metrics.NexusCallerTypeTag("namespace")) |
Contributor
Author
There was a problem hiding this comment.
Not sure if there's a better way to do this. callerInfo.CallerType seems to be something else (which is maybe a hint that using callerInfo at all is wrong here?).
Member
|
Not reviewing this yet since we have all of the metrics in different forms already. Let's see what @kepe-temporal comes back with. |
38923fc to
340f40a
Compare
7ae0421 to
414a003
Compare
ce242b7 to
397eca3
Compare
397eca3 to
7ae0421
Compare
e36b74b to
bcda346
Compare
Contributor
|
We can use the old metrics and rename them, but we can't split metrics across multiple tables on ingest depending on the value of a label. |
a44e612 to
44d2c2b
Compare
378e20c to
80b781d
Compare
6075a82 to
1c9aa39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
New Metrics:
Counters
nexus_request_error_countNew Labels:
For
nexus_requests,nexus_request_error_countandnexus_latency. Most of these were already set onnexus_requestsandnexus_latencynamespacenexus_endpointnexus_servicenexus_operationnexus_callernexus_caller_typeHow did you test it?