Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/architecture/nexus.md
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ workflow and operation state machine. The
[component.nexusoperations.callback.endpoint.template](https://github.com/temporalio/temporal/blob/7c8025aff96af7d72a91af615f1d625817842894/components/nexusoperations/config.go#L69)
global dynamic config must be set to construct callback URLs or the executor will fail to process invocation tasks. When
routing callbacks to external clusters and non-Temporal destinations, the URL is used and should be a value that is
publically accessible to those external destinations. Callbacks that are routed internally within the cluster resolve
publicly accessible to those external destinations. Callbacks that are routed internally within the cluster resolve
the frontend URL via membership or, as a last resort, via static configuration overrides.

The timeout for making a single Nexus HTTP call is configurable via: `component.nexusoperations.request.timeout`
Expand Down
2 changes: 1 addition & 1 deletion service/matching/matcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func (t *MatcherTestSuite) TestForwardingWhenBacklogIsYoung() {
wg.Add(1)
t.client.EXPECT().AddWorkflowTask(gomock.Any(), gomock.Any(), gomock.Any()).Do(
func(arg0 context.Context, arg1 *matchingservice.AddWorkflowTaskRequest, arg2 ...any) {
// Offer forwarding has occured
// Offer forwarding has occurred
wg.Done()
},
).Return(&matchingservice.AddWorkflowTaskResponse{}, errMatchingHostThrottleTest)
Expand Down
2 changes: 1 addition & 1 deletion tools/tdbg/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func NewCliApp(opts ...Option) *cli.App {
case "never":
color.NoColor = true
default:
// fatih/color will inspect the enviroment and terminal and set a reasonable default.
// fatih/color will inspect the environment and terminal and set a reasonable default.
}
return nil
}
Expand Down